Open
Conversation
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
dbraquart
requested changes
Jan 15, 2026
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: 2 types for modification vs map ?
tests: error on 2WT creation ?
...nts/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
Outdated
Show resolved
Hide resolved
...nts/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
Outdated
Show resolved
Hide resolved
...nts/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
Outdated
Show resolved
Hide resolved
...nts/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
…twt-creation # Conflicts: # src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx # src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.tsx # src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx # src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
dbraquart
requested changes
Feb 12, 2026
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: some changes to adress please
tests: ok (so far)
Comment on lines
+638
to
+639
| connectionPosition1: String(characteristics[CONNECTIVITY_1]?.[CONNECTION_POSITION]), | ||
| connectionPosition2: String(characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION]), |
Contributor
There was a problem hiding this comment.
Suggested change
| connectionPosition1: String(characteristics[CONNECTIVITY_1]?.[CONNECTION_POSITION]), | |
| connectionPosition2: String(characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION]), | |
| connectionPosition1: characteristics[CONNECTIVITY_1]?.[CONNECTION_POSITION], | |
| connectionPosition2: characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION], |
And connectionPosition1/connectionPosition2 should be typed number rather than string in TwoWindingsTransformerCreationInfo
| connectionPosition1: String(characteristics[CONNECTIVITY_1]?.[CONNECTION_POSITION]), | ||
| connectionPosition2: String(characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION]), | ||
| connected1: Boolean(characteristics[CONNECTIVITY_1]?.[CONNECTED]), | ||
| connected2: Boolean(characteristics[CONNECTIVITY_2]?.[CONNECTED]), |
Contributor
There was a problem hiding this comment.
either we cast, or we change the type as "boolean | null" ... dont know.
Casting is always a "force" move. And Boolean(null) == false.
But in our case it does not matter because there is always a value in the form for the connection boolean (I think).
| currentNode: CurrentTreeNode; | ||
| currentRootNetworkUuid: UUID; | ||
| isUpdate?: boolean; | ||
| editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus]; |
Contributor
There was a problem hiding this comment.
Suggested change
| editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus]; | |
| editDataFetchStatus?: FetchStatus; |
| currentRootNetworkUuid: UUID; | ||
| isUpdate?: boolean; | ||
| editData?: TwoWindingsTransformerModificationInfo; | ||
| editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus]; |
Contributor
There was a problem hiding this comment.
Suggested change
| editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus]; | |
| editDataFetchStatus?: FetchStatus; |
using enum type from services/utils.type
Comment on lines
+254
to
+256
| const [dataFetchStatus, setDataFetchStatus] = useState<(typeof FetchStatus)[keyof typeof FetchStatus]>( | ||
| FetchStatus.IDLE | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| const [dataFetchStatus, setDataFetchStatus] = useState<(typeof FetchStatus)[keyof typeof FetchStatus]>( | |
| FetchStatus.IDLE | |
| ); | |
| const [dataFetchStatus, setDataFetchStatus] = useState<FetchStatus>(FetchStatus.IDLE); |
| ) | ||
| : null, | ||
| targetV: getValueOrDefault(TARGET_V), | ||
| targetDeadband: getValueOrDefault(TARGET_DEADBAND), |
Contributor
There was a problem hiding this comment.
targetV/targetDeadband are already in ...ratioTapChangerFormValues
| regulationType: getValueOrDefault(REGULATION_TYPE), | ||
| }; | ||
| } | ||
| let phaseTap = undefined; |
Contributor
There was a problem hiding this comment.
same, we should type ?
let phaseTap: PhaseTapChangerCreationInfos | null = null;
rather than casting further
I tried, and attributes are missing ...
| disabled?: boolean; | ||
| previousValues?: RatioTapChangerData; | ||
| previousValues?: TapChangerMapInfos; | ||
| editData?: Record<string, unknown>; |
Contributor
There was a problem hiding this comment.
Suggested change
| editData?: Record<string, unknown>; | |
| editData?: TwoWindingsTransformerModificationInfo; |
| <RatioTapChangerPaneSteps | ||
| disabled={!ratioTapChangerEnabledWatcher} | ||
| previousValues={previousValues?.ratioTapChanger} | ||
| editData={editData?.ratioTapChanger as Record<string, unknown> | undefined} |
Contributor
There was a problem hiding this comment.
Suggested change
| editData={editData} |
Comment on lines
+51
to
+52
| connectivity1?: Record<string, unknown> | null; | ||
| connectivity2?: Record<string, unknown> | null; |
Contributor
There was a problem hiding this comment.
Suggested change
| connectivity1?: Record<string, unknown> | null; | |
| connectivity2?: Record<string, unknown> | null; | |
| connectivity1?: ConnectivityFormSchema | null; | |
| connectivity2?: ConnectivityFormSchema | null; |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary